From 0168300b0da3c79e05ec87aa777e04674a86cebb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Araujo?= Date: Sat, 14 Dec 2019 13:32:07 -0500 Subject: start reworking security policy --- tests/test_testing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test_testing.py') diff --git a/tests/test_testing.py b/tests/test_testing.py index ebeafe21d..d0f23a116 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -33,7 +33,7 @@ class TestDummySecurityPolicy(unittest.TestCase): def test_permits(self): policy = self._makeOne() - self.assertEqual(policy.permits(None, None, None, None), True) + self.assertTrue(policy.permits(None, None, None)) def test_forget(self): policy = self._makeOne() -- cgit v1.2.3 From 638125171a311b9a6ba7c02da844ca601a2b0e0e Mon Sep 17 00:00:00 2001 From: Theron Luhn Date: Sat, 14 Dec 2019 19:16:58 -0600 Subject: Fix tests for `DummySecurityPolicy`. --- tests/test_testing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test_testing.py') diff --git a/tests/test_testing.py b/tests/test_testing.py index ad1fca1d9..6eb474f65 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -25,7 +25,7 @@ class TestDummySecurityPolicy(unittest.TestCase): def _makeOne(self, identity=None, permissive=True): klass = self._getTargetClass() - return klass(identity, permissive) + return klass(identity, identity, permissive) def test_identify(self): policy = self._makeOne('user') -- cgit v1.2.3 From 2e06fa414412688dc3b7e0b422b0fc0b96ec882f Mon Sep 17 00:00:00 2001 From: Theron Luhn Date: Sat, 14 Dec 2019 20:17:36 -0800 Subject: Bring back identity into permits. --- tests/test_testing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test_testing.py') diff --git a/tests/test_testing.py b/tests/test_testing.py index 6eb474f65..a329b0a04 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -33,7 +33,7 @@ class TestDummySecurityPolicy(unittest.TestCase): def test_permits(self): policy = self._makeOne() - self.assertTrue(policy.permits(None, None, None)) + self.assertEqual(policy.permits(None, None, None, None), True) def test_forget(self): policy = self._makeOne() -- cgit v1.2.3 From 2e55311fec0a539dab87c2ee4b0d7781055dd98a Mon Sep 17 00:00:00 2001 From: Theron Luhn Date: Sat, 14 Dec 2019 23:21:25 -0800 Subject: Fix coverage. --- tests/test_testing.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'tests/test_testing.py') diff --git a/tests/test_testing.py b/tests/test_testing.py index a329b0a04..22bc7332b 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -23,13 +23,17 @@ class TestDummySecurityPolicy(unittest.TestCase): return DummySecurityPolicy - def _makeOne(self, identity=None, permissive=True): + def _makeOne(self, userid=None, identity=None, permissive=True): klass = self._getTargetClass() - return klass(identity, identity, permissive) + return klass(userid, identity, permissive) def test_identify(self): + policy = self._makeOne('user', 'identity') + self.assertEqual(policy.identify(None), 'identity') + + def test_authenticated_userid(self): policy = self._makeOne('user') - self.assertEqual(policy.identify(None), 'user') + self.assertEqual(policy.authenticated_userid(None), 'user') def test_permits(self): policy = self._makeOne() -- cgit v1.2.3 From 32bf9b3669f2ba0c4a0aaf35f4e2cdad8f9314f0 Mon Sep 17 00:00:00 2001 From: Theron Luhn Date: Sun, 15 Dec 2019 19:55:10 -0800 Subject: Revert "Bring back identity into permits." This reverts commit 2e06fa414412688dc3b7e0b422b0fc0b96ec882f. --- tests/test_testing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test_testing.py') diff --git a/tests/test_testing.py b/tests/test_testing.py index 22bc7332b..be519cd15 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -37,7 +37,7 @@ class TestDummySecurityPolicy(unittest.TestCase): def test_permits(self): policy = self._makeOne() - self.assertEqual(policy.permits(None, None, None, None), True) + self.assertTrue(policy.permits(None, None, None)) def test_forget(self): policy = self._makeOne() -- cgit v1.2.3