From 8e037fda9af695b608240d8fed085c403f657011 Mon Sep 17 00:00:00 2001
From: Chris McDonough <chrism@agendaless.com>
Date: Fri, 1 May 2009 09:06:54 +0000
Subject: - In previous releases, the ``repoze.bfg.url.model_url``,  
 ``repoze.bfg.traversal.model_path`` and  
 ``repoze.bfg.traversal.model_path_tuple`` functions always ignored   the
 ``__name__`` argument of the root object in a model graph (   effectively
 replacing it with a leading ``/`` in the returned value)   when a path or URL
 was generated.  The code required to perform this   operation was not
 efficient.  As of this release, the root object in   a model graph *must*
 have a ``__name__`` attribute that is either   ``None`` or the empty string
 (``''``) for URLs and paths to be   generated properly from these APIs.  If
 your root model object has a   ``__name__`` argument that is not one of these
 values, you will need   to change your code for URLs and paths to be
 generated properly.  If   your model graph has a root node with a string
 ``__name__`` that is   not null, the value of ``__name__`` will be prepended
 to every path   and URL generated.

---
 repoze/bfg/tests/test_traversal.py | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

(limited to 'repoze/bfg/tests')

diff --git a/repoze/bfg/tests/test_traversal.py b/repoze/bfg/tests/test_traversal.py
index f361d0a79..867dae318 100644
--- a/repoze/bfg/tests/test_traversal.py
+++ b/repoze/bfg/tests/test_traversal.py
@@ -384,7 +384,31 @@ class ModelPathTests(unittest.TestCase):
         root.__name__ = None
         result = self._callFUT(root)
         self.assertEqual(result, '/')
-        
+
+    def test_root_default_emptystring(self):
+        root = DummyContext()
+        root.__parent__ = None
+        root.__name__ = ''
+        result = self._callFUT(root)
+        self.assertEqual(result, '/')
+
+    def test_root_object_nonnull_name_direct(self):
+        root = DummyContext()
+        root.__parent__ = None
+        root.__name__ = 'flubadub'
+        result = self._callFUT(root)
+        self.assertEqual(result, 'flubadub') # insane case
+
+    def test_root_object_nonnull_name_indirect(self):
+        root = DummyContext()
+        root.__parent__ = None
+        root.__name__ = 'flubadub'
+        other = DummyContext()
+        other.__parent__ = root
+        other.__name__ = 'barker'
+        result = self._callFUT(other)
+        self.assertEqual(result, 'flubadub/barker') # insane case
+
     def test_nonroot_default(self):
         root = DummyContext()
         root.__parent__ = None
-- 
cgit v1.2.3