From 85078f4eb39c6827973292a628cdf5ff6b34249a Mon Sep 17 00:00:00 2001 From: Chris McDonough Date: Tue, 28 Oct 2008 23:12:41 +0000 Subject: - If the ``render_view_to_response`` function was called, if the view was found and called, but it returned something that did not implement IResponse, the error would pass by unflagged. This was noticed when I created a view function that essentially returned None, but received a NotFound error rather than a ValueError when the view was rendered. This was fixed. --- repoze/bfg/tests/test_view.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'repoze/bfg/tests/test_view.py') diff --git a/repoze/bfg/tests/test_view.py b/repoze/bfg/tests/test_view.py index 6eee8fbab..3636692a8 100644 --- a/repoze/bfg/tests/test_view.py +++ b/repoze/bfg/tests/test_view.py @@ -124,6 +124,27 @@ class RenderViewToResponseTests(unittest.TestCase, BaseTest): response = renderer(context, request, name='registered', secure=False) self.assertEqual(response.status, '200 OK') + + def test_call_view_response_doesnt_implement_IResponse(self): + context = DummyContext() + from zope.interface import Interface + from zope.interface import directlyProvides + from repoze.bfg.interfaces import IRequest + class IContext(Interface): + pass + directlyProvides(context, IContext) + response = 'abc' + view = make_view(response) + self._registerView(view, 'registered', IContext, IRequest) + environ = self._makeEnviron() + from webob import Request + request = Request(environ) + directlyProvides(request, IRequest) + renderer = self._getFUT() + self.assertRaises(ValueError, renderer, context, request, + name='registered', secure=False) + + class RenderViewToIterableTests(unittest.TestCase, BaseTest): def _getFUT(self): from repoze.bfg.view import render_view_to_iterable -- cgit v1.2.3