From 22e72d7ab95f3c1b363e6b9b13d5b35e72866647 Mon Sep 17 00:00:00 2001 From: Chris McDonough Date: Sun, 1 Nov 2009 18:49:07 +0000 Subject: - Header values returned by the ``authtktauthenticationpolicy`` ``remember`` and ``forget`` methods would be of type ``unicode`` if the ``cookie_name`` attribute was used in the ZCML declaration. This violated the WSGI spec, causing a ``TypeError`` to be raised when these headers were used under ``mod_wsgi``. - If a routes-only BFG app was mounted under a path in modwsgi, ala ``WSGIScriptAlias /myapp /Users/chrism/projects/modwsgi/env/bfg.wsgi``, the home route (a route with the path of ``'/'`` or ``''``) would not match when the path ``/myapp`` was visited (only when the path ``/myapp/`` was visited). This is now fixed: if the urldispatch root factory notes that the PATH_INFO is empty, it converts it to a single slash before trying to do matching. --- repoze/bfg/tests/test_urldispatch.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'repoze/bfg/tests/test_urldispatch.py') diff --git a/repoze/bfg/tests/test_urldispatch.py b/repoze/bfg/tests/test_urldispatch.py index 83e908994..803f4503f 100644 --- a/repoze/bfg/tests/test_urldispatch.py +++ b/repoze/bfg/tests/test_urldispatch.py @@ -194,6 +194,21 @@ class RoutesRootFactoryTests(unittest.TestCase): self.assertEqual(request.matchdict, {}) self.failUnless(req_iface.providedBy(request)) + def test_root_route_when_path_info_empty(self): + root_factory = DummyRootFactory(123) + req_iface = self._registerRouteRequest('root') + mapper = self._makeOne(root_factory) + mapper.connect('/', 'root') + request = self._getRequest(PATH_INFO='') + result = mapper(request) + environ = request.environ + self.assertEqual(result, 123) + self.assertEqual(environ['bfg.routes.route'].name, 'root') + self.assertEqual(environ['bfg.routes.matchdict'], {}) + self.assertEqual(environ['wsgiorg.routing_args'], ((), {})) + self.assertEqual(request.matchdict, {}) + self.failUnless(req_iface.providedBy(request)) + def test_fallback_to_default_root_factory(self): root_factory = DummyRootFactory(123) mapper = self._makeOne(root_factory) -- cgit v1.2.3