From 54251241c8f52dbe88d6ee21df9f2018fbd7c0d9 Mon Sep 17 00:00:00 2001 From: Michael Merickel Date: Thu, 12 Nov 2015 21:41:07 -0600 Subject: abort when using reload with daemon --- pyramid/scripts/pserve.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pyramid/scripts/pserve.py b/pyramid/scripts/pserve.py index 63f34f6c2..42b45640c 100644 --- a/pyramid/scripts/pserve.py +++ b/pyramid/scripts/pserve.py @@ -225,6 +225,10 @@ class PServeCommand(object): cmd = None if self.options.reload: + if self.options.daemon or cmd in ('start', 'stop', 'restart'): + self.out( + 'Error: Cannot use reloading while running as a dameon.') + return 2 if os.environ.get(self._reloader_environ_key): if self.options.verbose > 1: self.out('Running reloading file monitor') -- cgit v1.2.3 From 03465e75ba938a11e9f9c85b7829f7dea9713642 Mon Sep 17 00:00:00 2001 From: Michael Merickel Date: Thu, 12 Nov 2015 23:13:00 -0600 Subject: add changelog for #2119 --- CHANGES.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGES.txt b/CHANGES.txt index 77b8e9298..a17c7e1e6 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -235,6 +235,10 @@ Bug Fixes - Fixed usage of ``pserve --monitor-restart --daemon`` which would fail in horrible ways. See https://github.com/Pylons/pyramid/pull/2118 +- Explicitly prevent ``pserve --reload --daemon`` from being used. It's never + been supported but would work and fail in weird ways. + See https://github.com/Pylons/pyramid/pull/2119 + Deprecations ------------ -- cgit v1.2.3