From 5b9105ad8de57f21269608b1536720a5425a1fd1 Mon Sep 17 00:00:00 2001 From: Chris McDonough Date: Thu, 22 Jan 2009 08:41:42 +0000 Subject: Coverage. --- CHANGES.txt | 6 ++++++ repoze/bfg/lru.py | 9 --------- repoze/bfg/registry.py | 2 +- repoze/bfg/tests/test_lru.py | 10 +++++++++- 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 4739b9601..8e5321069 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -31,6 +31,12 @@ Implementation Changes - The ``is_response`` check was sped up by about half at the expense of making its code slightly uglier. +New Modules +=========== + +- ``repoze.bfg.lru`` implements an LRU cache class and a decorator for + internal use. + 0.6.3 (2009-01-19) ================== diff --git a/repoze/bfg/lru.py b/repoze/bfg/lru.py index 059750d15..d29142b3b 100644 --- a/repoze/bfg/lru.py +++ b/repoze/bfg/lru.py @@ -4,11 +4,6 @@ import threading _marker = object() -class Node(object): - def __init__(self, key): - self.key = key - self.ref = False - class LRUCache(object): def __init__(self, size): """ Implements a psueudo-LRU algorithm (CLOCK) """ @@ -88,7 +83,3 @@ class lru_cache(object): cache.put(key, val) return val return lru_cached - - - - diff --git a/repoze/bfg/registry.py b/repoze/bfg/registry.py index b9a74d885..26feb73e0 100644 --- a/repoze/bfg/registry.py +++ b/repoze/bfg/registry.py @@ -44,7 +44,7 @@ class Registry(Components): if self._has_listeners: # iterating over subscribers assures they get executed for ignored in self.subscribers(events, None): - pass + """ """ class ThreadLocalRegistryManager(threading.local): def __init__(self): diff --git a/repoze/bfg/tests/test_lru.py b/repoze/bfg/tests/test_lru.py index 02bee3052..c5224420b 100644 --- a/repoze/bfg/tests/test_lru.py +++ b/repoze/bfg/tests/test_lru.py @@ -8,6 +8,9 @@ class LRUCacheTests(unittest.TestCase): def _makeOne(self, size): return self._getTargetClass()(size) + def test_size_lessthan_1(self): + self.assertRaises(ValueError, self._makeOne, 0) + def test_it(self): cache = self._makeOne(3) self.assertEqual(cache.get('a'), None) @@ -41,7 +44,12 @@ class LRUCacheTests(unittest.TestCase): cache.put('e', '5') self.assertEqual(len(cache.data), 3) self.assertEqual(cache.data.get('c'), None) - + self.assertEqual(cache.get('d'), '4') + self.assertEqual(cache.get('e'), '5') + self.assertEqual(cache.get('a'), '1') + self.assertEqual(cache.get('b'), None) + self.assertEqual(cache.get('c'), None) + class DecoratorTests(unittest.TestCase): def _getTargetClass(self): from repoze.bfg.lru import lru_cache -- cgit v1.2.3