diff options
| -rw-r--r-- | CHANGES.txt | 9 | ||||
| -rw-r--r-- | repoze/bfg/router.py | 5 |
2 files changed, 11 insertions, 3 deletions
diff --git a/CHANGES.txt b/CHANGES.txt index 8a151729c..b7a715ebd 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -83,6 +83,15 @@ Internal request factory (the previous return value of the now-missing ``repoze.bfg.request.create_route_request_factory``. +Backwards Incompatibilities +--------------------------- + +- Explicitly revert the feature introduced in 1.1a8: where the name + ``root`` is available as an attribute of the request before a + NewRequest event is emitted. This makes some potential future + features impossible, or at least awkward (such as grouping traversal + and view lookup into a single adapter lookup). + 1.1a8 (2009-10-27) ================== diff --git a/repoze/bfg/router.py b/repoze/bfg/router.py index c48a96664..fbc4fef75 100644 --- a/repoze/bfg/router.py +++ b/repoze/bfg/router.py @@ -64,10 +64,10 @@ class Router(object): threadlocals['request'] = request attrs = request.__dict__ attrs['registry'] = registry + registry.has_listeners and registry.notify(NewRequest(request)) + root = self.root_factory(request) attrs['root'] = root - - registry.has_listeners and registry.notify(NewRequest(request)) traverser = registry.queryAdapter(root, ITraverser) if traverser is None: traverser = ModelGraphTraverser(root) @@ -77,7 +77,6 @@ class Router(object): tdict['traversed'], tdict['virtual_root'], tdict['virtual_root_path']) attrs.update(tdict) - provides = map(providedBy, (context, request)) view_callable = registry.adapters.lookup( provides, IView, name=view_name, default=None) |