summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTheron Luhn <theron@luhn.com>2019-12-15 19:55:10 -0800
committerTheron Luhn <theron@luhn.com>2019-12-15 19:55:10 -0800
commit32bf9b3669f2ba0c4a0aaf35f4e2cdad8f9314f0 (patch)
tree6e9a4b0ff52843571799aa693725f22b6054662e /src
parent7b74e97fd156bef6b8f347d7d38615d5bea6c967 (diff)
downloadpyramid-32bf9b3669f2ba0c4a0aaf35f4e2cdad8f9314f0.tar.gz
pyramid-32bf9b3669f2ba0c4a0aaf35f4e2cdad8f9314f0.tar.bz2
pyramid-32bf9b3669f2ba0c4a0aaf35f4e2cdad8f9314f0.zip
Revert "Bring back identity into permits."
This reverts commit 2e06fa414412688dc3b7e0b422b0fc0b96ec882f.
Diffstat (limited to 'src')
-rw-r--r--src/pyramid/interfaces.py2
-rw-r--r--src/pyramid/security.py6
-rw-r--r--src/pyramid/testing.py2
-rw-r--r--src/pyramid/viewderivers.py9
4 files changed, 7 insertions, 12 deletions
diff --git a/src/pyramid/interfaces.py b/src/pyramid/interfaces.py
index d20401028..891b851ee 100644
--- a/src/pyramid/interfaces.py
+++ b/src/pyramid/interfaces.py
@@ -494,7 +494,7 @@ class ISecurityPolicy(Interface):
verified user, or ``None`` if unauthenticated.
"""
- def permits(request, context, identity, permission):
+ def permits(request, context, permission):
""" Return an instance of :class:`pyramid.security.Allowed` if a user
of the given identity is allowed the ``permission`` in the current
``context``, else return an instance of
diff --git a/src/pyramid/security.py b/src/pyramid/security.py
index d6af69e51..e3a978c52 100644
--- a/src/pyramid/security.py
+++ b/src/pyramid/security.py
@@ -351,9 +351,7 @@ class SecurityAPIMixin:
policy = _get_security_policy(self)
if policy is None:
return Allowed('No security policy in use.')
- return policy.permits(
- self, context, self.authenticated_identity, permission
- )
+ return policy.permits(self, context, permission)
class AuthenticationAPIMixin(object):
@@ -449,7 +447,7 @@ class LegacySecurityPolicy:
authn = self._get_authn_policy(request)
return authn.forget(request)
- def permits(self, request, context, identity, permission):
+ def permits(self, request, context, permission):
authn = self._get_authn_policy(request)
authz = self._get_authz_policy(request)
principals = authn.effective_principals(request)
diff --git a/src/pyramid/testing.py b/src/pyramid/testing.py
index f550156dd..a92bb5d03 100644
--- a/src/pyramid/testing.py
+++ b/src/pyramid/testing.py
@@ -64,7 +64,7 @@ class DummySecurityPolicy(object):
def authenticated_userid(self, request):
return self.userid
- def permits(self, request, context, identity, permission):
+ def permits(self, request, context, permission):
return self.permissive
def remember(self, request, userid, **kw):
diff --git a/src/pyramid/viewderivers.py b/src/pyramid/viewderivers.py
index 35f9a08d2..7c28cbf85 100644
--- a/src/pyramid/viewderivers.py
+++ b/src/pyramid/viewderivers.py
@@ -316,8 +316,7 @@ def _secured_view(view, info):
if policy and (permission is not None):
def permitted(context, request):
- identity = policy.identify(request)
- return policy.permits(request, context, identity, permission)
+ return policy.permits(request, context, permission)
def secured_view(context, request):
result = permitted(context, request)
@@ -363,10 +362,8 @@ def _authdebug_view(view, info):
elif permission is None:
msg = 'Allowed (no permission registered)'
else:
- identity = policy.identify(request)
- msg = str(
- policy.permits(request, context, identity, permission)
- )
+ result = policy.permits(request, context, permission)
+ msg = str(result)
else:
msg = 'Allowed (no security policy in use)'