- The ``repoze.bfg.interfaces.INewResponse`` interface now includes a

  ``request`` attribute; as a result, a handler for INewResponse now
  has access to the request which caused the response.

- The INewResponse event is now not sent to listeners if the response
  returned by view code (or a renderer) is not a "real" response
  (e.g. if it does not have ``.status``, ``.headerlist`` and
  ``.app_iter`` attribtues).

1 files changed, 7 insertions, 4 deletions

diff --git a/repoze/bfg/tests/test_events.py b/repoze/bfg/tests/test_events.py
index c258c4ad2..c122f4744 100644
--- a/repoze/bfg/tests/test_events.py
+++ b/repoze/bfg/tests/test_events.py
@@ -31,8 +31,8 @@ class NewResponseEventTests(unittest.TestCase):
         from repoze.bfg.events import NewResponse
         return NewResponse
 
-    def _makeOne(self, response):
-        return self._getTargetClass()(response)
+    def _makeOne(self, request, response):
+        return self._getTargetClass()(request, response)
 
     def test_class_implements(self):
         from repoze.bfg.interfaces import INewResponse
@@ -43,13 +43,16 @@ class NewResponseEventTests(unittest.TestCase):
     def test_instance_implements(self):
         from repoze.bfg.interfaces import INewResponse
         from zope.interface.verify import verifyObject
+        request = DummyRequest()
         response = DummyResponse()
-        inst = self._makeOne(response)
+        inst = self._makeOne(request, response)
         verifyObject(INewResponse, inst)
 
     def test_ctor(self):
+        request = DummyRequest()
         response = DummyResponse()
-        inst = self._makeOne(response)
+        inst = self._makeOne(request, response)
+        self.assertEqual(inst.request, request)
         self.assertEqual(inst.response, response)
 
 class WSGIAppEventTests(unittest.TestCase):