diff options
| author | Steve Piercy <web@stevepiercy.com> | 2017-05-12 01:27:20 -0700 |
|---|---|---|
| committer | Steve Piercy <web@stevepiercy.com> | 2017-05-12 01:27:20 -0700 |
| commit | dede5366e8b2ce5982806f4306cdaaa6c8e178ca (patch) | |
| tree | 5a9d27d5f518d1abc5e89c5a5a00b6d409781671 /docs | |
| parent | 0b92dfed800117595ef00fb2847c5db9970f4cac (diff) | |
| parent | 4e27dd4c452a67d38a07eb79939dcbfcc6e82ab0 (diff) | |
| download | pyramid-dede5366e8b2ce5982806f4306cdaaa6c8e178ca.tar.gz pyramid-dede5366e8b2ce5982806f4306cdaaa6c8e178ca.tar.bz2 pyramid-dede5366e8b2ce5982806f4306cdaaa6c8e178ca.zip | |
Merge remote-tracking branch 'upstream/master'
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/conf.py | 2 | ||||
| -rw-r--r-- | docs/whatsnew-1.9.rst | 9 |
2 files changed, 10 insertions, 1 deletions
diff --git a/docs/conf.py b/docs/conf.py index f09ae325b..e63019c63 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -70,7 +70,7 @@ intersphinx_mapping = { 'plaster': ('http://docs.pylonsproject.org/projects/plaster/en/latest/', None), 'pylonswebframework': ('http://docs.pylonsproject.org/projects/pylons-webframework/en/latest/', None), 'python': ('https://docs.python.org/3', None), - 'pytest': ('http://pytest.org/latest/', None), + 'pytest': ('https://pytest.org/en/latest/', None), 'sphinx': ('http://www.sphinx-doc.org/en/latest', None), 'sqla': ('http://docs.sqlalchemy.org/en/latest', None), 'tm': ('http://docs.pylonsproject.org/projects/pyramid-tm/en/latest/', None), diff --git a/docs/whatsnew-1.9.rst b/docs/whatsnew-1.9.rst index b1a406a74..0ba29625c 100644 --- a/docs/whatsnew-1.9.rst +++ b/docs/whatsnew-1.9.rst @@ -46,6 +46,15 @@ Deprecations See https://github.com/Pylons/pyramid/pull/2854 and https://github.com/Pylons/pyramid/pull/3019 +Backward Incompatibilities +-------------------------- + +- ``request.exception`` and ``request.exc_info`` will only be set if the response was generated by the EXCVIEW tween. This is to avoid any confusion where a response was generated elsewhere in the pipeline and not in direct relation to the original exception. If anyone upstream wants to catch and render responses for exceptions they should set ``request.exception`` and ``request.exc_info`` themselves to indicate the exception that was squashed when generating the response. + + Similar behavior occurs with :meth:`pyramid.request.Request.invoke_exception_view` in which the exception properties are set to reflect the exception if a response is successfully generated by the method. + + This is a very minor incompatibility. Most tweens right now would give priority to the raised exception and ignore ``request.exception``. This change just improves and clarifies that bookkeeping by trying to be more clear about the relationship between the response and its squashed exception. See https://github.com/Pylons/pyramid/pull/3029 and https://github.com/Pylons/pyramid/pull/3031 + Documentation Enhancements -------------------------- |
