Remove match_val feature: it's a pretty nuisance

3 files changed, 10 insertions, 63 deletions

diff --git a/docs/narr/views.rst b/docs/narr/views.rst
index 9b7d6b2dd..eebaa63de 100644
--- a/docs/narr/views.rst
+++ b/docs/narr/views.rst
@@ -1358,33 +1358,6 @@ Predicate Arguments
   taken into consideration when deciding whether or not to invoke the
   associated view callable.
 
-``match_val``
-
-  This value represents :term:`URL dispatch` ``request.matchdict``
-  name or a matchdict name/value pair.  ``request.matchdict`` is a
-  dictionary representing the match values from the route pattern
-  (e.g. if the route pattern has ``:foo`` in it, and the route
-  matches, a key will exist in the matchdict named ``foo``).
-
-  If ``match_val`` is specified, it must be the name of a key presumed
-  to be present in the ``matchdict`` or a ``key:regex`` pair.
-
-  If ``match_val`` is specified without a colon in it
-  (e.g. ``action``), the predicate will return true if the
-  ``matchdict`` has a key which exists with any value.
-
-  When the ``match_val`` contains a ``:`` (colon), it will be split at
-  the first colon; the left hand of that split will considered a key
-  and the right hand a regular expression.  For example, in
-  ``action:\w+\.html``, the key part is ``action``, the regex part is
-  ``\w+\.html``.  The resulting predicate will only be true if the
-  matchdict contains a key that matches the key part *and* the
-  matchdict value is matched by the regex part.
-
-  If ``match_val`` is not specified, the composition, presence or
-  absence of values in the matchdict is not taken into consideration
-  when deciding whether or not to invoke the associated view callable.
-
 ``custom_predicates``
   If ``custom_predicates`` is specified, it must be a sequence of
   references to custom predicate callables.  Use custom predicates
diff --git a/docs/whatsnew-1.3.rst b/docs/whatsnew-1.3.rst
index f55ac88a6..48fe8f4f0 100644
--- a/docs/whatsnew-1.3.rst
+++ b/docs/whatsnew-1.3.rst
@@ -158,18 +158,6 @@ Minor Feature Additions
   media package-internal and served by the development webserver
   during development.
 
-- A new :ref:`view predicate` was added named ``match_val``.  The
-  ``match_val`` value represents the presence of a value in the
-  structure added to the request named ``matchdict`` during :term:`URL
-  dispatch` representing the match values from the route pattern
-  (e.g. if the route pattern has ``:foo`` in it, and the route
-  matches, a key will exist in the matchdict named ``foo``).  Like all
-  other view predicates, this feature is exposed via the
-  :class:`repoze.bfg.view.bfg_view` API, the
-  :class:`repoze.bfg.configuration.Configurator.add_view` API, and the
-  ZCML :ref:`view_directive` directive.  See the documentation for
-  those APIs for more inforamtion.
-
 - New argument to
   :class:`repoze.bfg.configuration.Configurator.add_route` and the
   ZCML ``route`` directive: ``traverse``.  If you would like to cause
@@ -182,6 +170,13 @@ Minor Feature Additions
   :class:`repoze.bfg.configuration.Configurator.add_route` for more
   information (the ``traverse`` argument).
 
+- A new method of the ``Configurator`` exists:
+  ``set_request_factory``.  If used, this method will set the factory
+  used by the :mod:`repoze.bfg` router to create all request objects.
+  The ``Configurator`` constructor also takes an additional argument:
+  ``request_factory``.  If used, this argument will set the factory
+  used by the :mod:`repoze.bfg` router to create all request objects.
+
 Backwards Incompatibilities
 ---------------------------
 
@@ -248,6 +243,9 @@ Documentation Enhancements
   changed to demonstrate authorization via a group rather than via a
   direct username.
 
+- The :ref:`hooks_chapter` chapter now contains a section about
+  changing the request factory.
+
 Licensing Changes
 -----------------
 
diff --git a/docs/zcml/view.rst b/docs/zcml/view.rst
index 9fe63738b..d33a9a9a5 100644
--- a/docs/zcml/view.rst
+++ b/docs/zcml/view.rst
@@ -224,30 +224,6 @@ Predicate Attributes
 
   .. note:: This feature is new as of :mod:`repoze.bfg` 1.1.
 
-``match_val``
-
-  The ``match_val`` value represents the presence of a value in the
-  :term:`URL dispatch` structure added to the request named
-  ``matchdict``.  ``matchdict`` represents the match values from the
-  route pattern (e.g. if the route pattern has ``:foo`` in it, and the
-  route matches, a key will exist in the matchdict named ``foo``).  If
-  the value does not contain a colon, the entire value will be
-  considered to be the name of a matchdict key (e.g. ``action``). If
-  the value does contain a ``:`` (colon), it will be considered a
-  name/value pair (e.g. ``action:generate.html`` or
-  ``action:\w+.html``).  The right hand side following the colon
-  should be a regular expression.
-
-  If the value does not contain a colon, the key specified by the name
-  must be present in the URL dispatch matchdict for this predicate to
-  be true; the value of the key is ignored.  If the value does contain
-  a colon, the name implied by the right hand must be present in the
-  matchdict *and* the regular expression specified on the right hand
-  side of the colon must match the value for the name in the matchdict
-  for this predicate to be true.
-
-  .. note:: This feature is new as of :mod:`repoze.bfg` 1.3.
-
 ``custom_predicates``
   This value should be a sequence of references to custom predicate
   callables (e.g. ``dotted.name.one dotted.name.two``, if used in