diff options
| author | jonathan vanasco <jonathan@2xlp.com> | 2019-11-04 17:45:44 -0500 |
|---|---|---|
| committer | jonathan vanasco <jonathan@2xlp.com> | 2019-11-05 16:51:11 -0500 |
| commit | 9264004c92adf731cd8164a63e199558ffdd2751 (patch) | |
| tree | 644f5b2c8aa055e28e8d67b3d863c7d2dbec2536 /docs/narr | |
| parent | 1d2b4fd13edc972dd4076500b1ec4cb972bef1c9 (diff) | |
| download | pyramid-9264004c92adf731cd8164a63e199558ffdd2751.tar.gz pyramid-9264004c92adf731cd8164a63e199558ffdd2751.tar.bz2 pyramid-9264004c92adf731cd8164a63e199558ffdd2751.zip | |
changes based on feedback
Diffstat (limited to 'docs/narr')
| -rw-r--r-- | docs/narr/sessions.rst | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/docs/narr/sessions.rst b/docs/narr/sessions.rst index 413dc5b8e..d9befec82 100644 --- a/docs/narr/sessions.rst +++ b/docs/narr/sessions.rst @@ -101,10 +101,14 @@ Remember that sessions should be short-lived and thus the number of clients affe self.json = JSONSerializer() def dumps(self, appstruct): - """Accept a Python object and return bytes.""" - # maybe catch serialization errors here and keep using pickle - # while finding spots in your app that are not storing - # JSON-serializable objects, falling back to pickle + """ + Accept a Python object and return bytes. + + During a migration, you may want to catch serialization errors here, + and keep using pickle while finding spots in your app that are not + storing JSON-serializable objects. You may also want to integrate + a fall-back to picke serialization here as well. + """ return self.json.dumps(appstruct) def loads(self, bstruct): @@ -114,8 +118,9 @@ Remember that sessions should be short-lived and thus the number of clients affe except ValueError: try: return pickle.loads(bstruct) - # at least ValueError, AttributeError, ImportError but more to be safe except Exception: + # this block should catch at least: + # ValueError, AttributeError, ImportError; but more to be safe raise ValueError # somewhere in your configuration code |
