summaryrefslogtreecommitdiff
path: root/contributing.md
diff options
context:
space:
mode:
authorAmos Latteier <amos@latteier.com>2016-06-30 10:17:43 -0700
committerAmos Latteier <amos@latteier.com>2016-06-30 10:17:43 -0700
commit35209e4ac53520e1159bd8a6b47128f38a75db18 (patch)
tree85b0f7e8e3794d8980dd10c10b7e57a862e694aa /contributing.md
parent3fd41dcb5a94a73f43862f6d5c063af7b54e6ff3 (diff)
parentbcba92d1b23745d736bdcbc9b799929de382db7b (diff)
downloadpyramid-35209e4ac53520e1159bd8a6b47128f38a75db18.tar.gz
pyramid-35209e4ac53520e1159bd8a6b47128f38a75db18.tar.bz2
pyramid-35209e4ac53520e1159bd8a6b47128f38a75db18.zip
Merge branch 'master' into exception_only
Diffstat (limited to 'contributing.md')
-rw-r--r--contributing.md44
1 files changed, 23 insertions, 21 deletions
diff --git a/contributing.md b/contributing.md
index ae201d370..b5f17ae06 100644
--- a/contributing.md
+++ b/contributing.md
@@ -56,11 +56,15 @@ System](http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/install.ht
git clone git@github.com:<username>/pyramid.git
-3. Add a git remote "upstream" for the cloned fork.
+3. Change directories into the cloned repository
+
+ cd pyramid
+
+4. Add a git remote "upstream" for the cloned fork.
git remote add upstream git@github.com:Pylons/pyramid.git
-4. Set an environment variable as instructed in the
+5. Create a virtual environment and set an environment variable as instructed in the
[prerequisites](https://github.com/Pylons/pyramid/blob/master/HACKING.txt#L55-L58).
# Mac and Linux
@@ -69,36 +73,34 @@ System](http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/install.ht
# Windows
set VENV=c:\hack-on-pyramid\env
-5. Try to build the docs in your workspace.
+6. Install `tox` into your virtual environment.
- # Mac and Linux
- $ make clean html SPHINXBUILD=$VENV/bin/sphinx-build
+ $ $VENV/bin/pip install tox
- # Windows
- c:\> make clean html SPHINXBUILD=%VENV%\bin\sphinx-build
+7. Try to build the docs in your workspace.
+
+ $ $VENV/bin/tox -e docs
- If successful, then you can make changes to the documentation. You can
- load the built documentation in the `/_build/html/` directory in a web
- browser.
+ When the build finishes, you'll find HTML documentation rendered in
+ `.tox/docs/html`. An `epub` version will be in `.tox/docs/epub`. And the
+ result of the tests that are run on the documentation will be in
+ `.tox/docs/doctest`.
-6. From this point forward, follow the typical [git
+8. From this point forward, follow the typical [git
workflow](https://help.github.com/articles/what-is-a-good-git-workflow/).
- Start by pulling from the upstream to get the most current changes.
+ *Always* start by pulling from the upstream to get the most current changes.
git pull upstream master
-7. Make a branch, make changes to the docs, and rebuild them as indicated in
- step 5. To speed up the build process, you can omit `clean` from the above
- command to rebuild only those pages that depend on the files you have
- changed.
+9. Make a branch, make changes to the docs, and rebuild them as indicated above.
-8. Once you are satisfied with your changes and the documentation builds
- successfully without errors or warnings, then git commit and push them to
- your "origin" repository on GitHub.
+10. Once you are satisfied with your changes and the documentation builds
+ successfully without errors or warnings, then git commit and push them to
+ your "origin" repository on GitHub.
git commit -m "commit message"
git push -u origin --all # first time only, subsequent can be just 'git push'.
-9. Create a [pull request](https://help.github.com/articles/using-pull-requests/).
+11. Create a [pull request](https://help.github.com/articles/using-pull-requests/).
-10. Repeat the process starting from Step 6.
+12. Repeat the process starting from Step 8.