summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBert JW Regeer <bertjw@regeer.org>2016-04-14 11:21:28 -0600
committerBert JW Regeer <bertjw@regeer.org>2016-04-14 11:21:28 -0600
commit42764f6cc89a57a9663274f48daf9bfc820f1c70 (patch)
tree545f0e24abe77cd058e09b79d660ba1adde4c6b0
parent4bb2095ae761474e072e190641c3645df971a2f5 (diff)
downloadpyramid-42764f6cc89a57a9663274f48daf9bfc820f1c70.tar.gz
pyramid-42764f6cc89a57a9663274f48daf9bfc820f1c70.tar.bz2
pyramid-42764f6cc89a57a9663274f48daf9bfc820f1c70.zip
Switch to sha512 in AuthTktAuthenticationPolicy
-rw-r--r--pyramid/authentication.py28
1 files changed, 1 insertions, 27 deletions
diff --git a/pyramid/authentication.py b/pyramid/authentication.py
index 9bf1de62e..71b2ec623 100644
--- a/pyramid/authentication.py
+++ b/pyramid/authentication.py
@@ -417,8 +417,6 @@ class RemoteUserAuthenticationPolicy(CallbackAuthenticationPolicy):
be done somewhere else or in a subclass."""
return []
-_marker = object()
-
@implementer(IAuthenticationPolicy)
class AuthTktAuthenticationPolicy(CallbackAuthenticationPolicy):
"""A :app:`Pyramid` :term:`authentication policy` which
@@ -601,34 +599,10 @@ class AuthTktAuthenticationPolicy(CallbackAuthenticationPolicy):
http_only=False,
wild_domain=True,
debug=False,
- hashalg=_marker,
+ hashalg='sha512',
parent_domain=False,
domain=None,
):
- if hashalg is _marker:
- hashalg = 'md5'
- warnings.warn(
- 'The MD5 hash function used by default by the '
- 'AuthTktAuthenticationPolicy is known to be '
- 'susceptible to collision attacks. It is the current default '
- 'for backwards compatibility reasons, but we recommend that '
- 'you use the SHA512 algorithm instead for improved security. '
- 'Pass ``hashalg=\'sha512\'`` to the '
- 'AuthTktAuthenticationPolicy constructor to do so.\n\nNote '
- 'that a change to the hash algorithms will invalidate existing '
- 'auth tkt cookies set by your application. If backwards '
- 'compatibility of existing auth tkt cookies is of greater '
- 'concern than the risk posed by the potential for a hash '
- 'collision, you\'ll want to continue using MD5 explicitly. '
- 'To do so, pass ``hashalg=\'md5\'`` in your application to '
- 'the AuthTktAuthenticationPolicy constructor. When you do so '
- 'this warning will not be emitted again. The default '
- 'algorithm used in this policy will change in the future, so '
- 'setting an explicit hashalg will futureproof your '
- 'application.',
- DeprecationWarning,
- stacklevel=2
- )
self.cookie = AuthTktCookieHelper(
secret,
cookie_name=cookie_name,