summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Merickel <michael@merickel.org>2017-05-03 14:05:19 -0500
committerMichael Merickel <michael@merickel.org>2017-05-03 14:05:19 -0500
commit3213e20f58d1a0b339e9d5bf9378ec54593624c7 (patch)
treef7b3fc5cc30f0f58496f10eb9ba713164da3baf2
parent2edbd967ef8f017f53a565d913556c38f545bbaf (diff)
downloadpyramid-3213e20f58d1a0b339e9d5bf9378ec54593624c7.tar.gz
pyramid-3213e20f58d1a0b339e9d5bf9378ec54593624c7.tar.bz2
pyramid-3213e20f58d1a0b339e9d5bf9378ec54593624c7.zip
add changelog for #3029
-rw-r--r--CHANGES.txt17
1 files changed, 17 insertions, 0 deletions
diff --git a/CHANGES.txt b/CHANGES.txt
index 2378ec883..b299ed6e9 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -114,6 +114,23 @@ Deprecations
See https://github.com/Pylons/pyramid/pull/2854 and
https://github.com/Pylons/pyramid/pull/3019
+Backward Incompatibilities
+--------------------------
+
+- ``request.exception`` and ``request.exc_info`` will only be set if the
+ response was generated by the EXCVIEW tween. This is to avoid any confusion
+ where a response was generated elsewhere in the pipeline and not in
+ direct relation to the original exception. If anyone upstream wants to
+ catch and render responses for exceptions they should set
+ ``request.exception`` and ``request.exc_info`` themselves to indicate
+ the exception that was squashed when generating the response.
+
+ This is a very minor incompatibility. Most tweens right now would give
+ priority to the raised exception and ignore ``request.exception``. This
+ change just improves and clarifies that bookkeeping by trying to be
+ more clear about the relationship between the response and its squashed
+ exception. See https://github.com/Pylons/pyramid/pull/3029
+
Documentation Changes
---------------------