summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorflibustenet <flibustenet@users.noreply.github.com>2014-04-17 21:52:23 +0200
committerflibustenet <flibustenet@users.noreply.github.com>2014-04-17 21:52:23 +0200
commit2af00e59d9c3e19b25e2759832efe6485a617536 (patch)
treeea7f2ad4067bcae184c8393e62d1ef53eca0ad1e
parentb666df0d5f299eca20e9370ac43cddee71b6dd06 (diff)
downloadpyramid-2af00e59d9c3e19b25e2759832efe6485a617536.tar.gz
pyramid-2af00e59d9c3e19b25e2759832efe6485a617536.tar.bz2
pyramid-2af00e59d9c3e19b25e2759832efe6485a617536.zip
More explicit example of set_property
cleanup callback has a "request" parameter (and not "_") cleanup callback know (since 1.5) if an exception occurred or not (to commit or rollback) (same as #1302 on 1.5)
-rw-r--r--docs/api/request.rst8
1 files changed, 7 insertions, 1 deletions
diff --git a/docs/api/request.rst b/docs/api/request.rst
index 343d0c022..c52d41400 100644
--- a/docs/api/request.rst
+++ b/docs/api/request.rst
@@ -319,7 +319,13 @@
def _connect(request):
conn = request.registry.dbsession()
- def cleanup(_):
+ def cleanup(request):
+ # since version 1.5 request.exception is not more
+ # eagerly cleared
+ if request.exception is not None:
+ conn.rollback()
+ else:
+ conn.commit()
conn.close()
request.add_finished_callback(cleanup)
return conn