From 65bd385540db567751405df000f6b063226d8b8a Mon Sep 17 00:00:00 2001 From: Daniel Schadt Date: Tue, 29 Sep 2020 17:23:01 +0200 Subject: return Outcome::Success if a raid was rewarded If the reward has been given out, we can be 99.9% sure that the fight succeeded, in which case we don't need to do any other convuluted checking. This has the benefit of catching some false-negatives (edge cases in success detection), at the cost of making the detection a bit ... weirder, in the sense that a log's success might now depend on whether it was the first kill in the week or not. However, given that our sucess detection works pretty well overall, I'd say it's worth to catch a few more false-negatives and try to classify as many logs correctly as possible. At least, this does not introduce any false-positives. --- src/analyzers/raids/w5.rs | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/analyzers/raids/w5.rs') diff --git a/src/analyzers/raids/w5.rs b/src/analyzers/raids/w5.rs index 578cea8..f914031 100644 --- a/src/analyzers/raids/w5.rs +++ b/src/analyzers/raids/w5.rs @@ -38,6 +38,7 @@ impl<'log> Analyzer for SoullessHorror<'log> { } fn outcome(&self) -> Option { + check_reward!(self.log); Outcome::from_bool(self.log.events().iter().any(|event| { if let EventKind::BuffApplication { buff_id, @@ -85,6 +86,7 @@ impl<'log> Analyzer for Dhuum<'log> { } fn outcome(&self) -> Option { + check_reward!(self.log); Outcome::from_bool(helpers::boss_is_dead(self.log)) } } -- cgit v1.2.3