diff options
| author | Daniel Schadt <kingdread@gmx.de> | 2021-11-13 12:09:02 +0100 |
|---|---|---|
| committer | Daniel Schadt <kingdread@gmx.de> | 2021-11-13 12:09:02 +0100 |
| commit | d98c391571ac41af08757c3fb87beef0a6415d23 (patch) | |
| tree | b3744e7de930f3fd13e82a80720ff84002c3c4ee /CHANGELOG.md | |
| parent | 0aee5f34c9f384656740666c6fdc03ccf537d2a3 (diff) | |
| download | evtclib-d98c391571ac41af08757c3fb87beef0a6415d23.tar.gz evtclib-d98c391571ac41af08757c3fb87beef0a6415d23.tar.bz2 evtclib-d98c391571ac41af08757c3fb87beef0a6415d23.zip | |
Document panic in Log::boss and remove other panic
Overall, evtclib is doing quite well on the .unwrap()/.expect()/panic!()
calls, except for some doctests (which can be changed at some point) and
the actual tests.
One case where we do panic (and should document it!) is Log::boss. The
documentation has been added there.
Another (rare if not impossible for proper evtc files) case was the
conversion of the language event, which assumed that we will definitely
be able to convert the u64 to the right language. In all normal cases
this should be true, but if evtclib deals with untrusted input, we might
not want to panic a whole program because someone smuggled in a
malicious file.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 5701aa7..92c594b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ All notable changes to this project will be documented in this file. - Boss and encounter definitions for the training golems (`StandardKittyGolem`, `MediumKittyGolem`, `LargeKittyGolem`) - `Log::is_generic` to check whether a log is generic (WvW) +- `FromRawEventError::UnknownLanguage` has been added to deal with an invalid + language byte. ### Fixed - `evtclib` will no longer choke on WvW logs where player names might not contain the expected |