diff options
| author | Daniel Schadt <kingdread@gmx.de> | 2020-09-29 17:23:01 +0200 |
|---|---|---|
| committer | Daniel Schadt <kingdread@gmx.de> | 2020-09-29 17:25:26 +0200 |
| commit | 65bd385540db567751405df000f6b063226d8b8a (patch) | |
| tree | 10592aaed4104bef4b39aa908a9943eb2eec50a2 /CHANGELOG.md | |
| parent | ed23bdb5f2d4790ab91628a690483b15089c2a55 (diff) | |
| download | evtclib-65bd385540db567751405df000f6b063226d8b8a.tar.gz evtclib-65bd385540db567751405df000f6b063226d8b8a.tar.bz2 evtclib-65bd385540db567751405df000f6b063226d8b8a.zip | |
return Outcome::Success if a raid was rewarded
If the reward has been given out, we can be 99.9% sure that the fight
succeeded, in which case we don't need to do any other convuluted
checking. This has the benefit of catching some false-negatives (edge
cases in success detection), at the cost of making the detection a bit
... weirder, in the sense that a log's success might now depend on
whether it was the first kill in the week or not.
However, given that our sucess detection works pretty well overall, I'd
say it's worth to catch a few more false-negatives and try to classify
as many logs correctly as possible. At least, this does not introduce
any false-positives.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 60937a6..2d9a506 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,10 @@ All notable changes to this project will be documented in this file. `evtclib::Encounter` is exported. - Renamed `Log::npcs` to `Log::characters` to have consistent naming. +### Fixed +- Some edge cases where raid success was not detected (as long as the fight was + rewarded). + ### Removed - Various `*_ID` constants from `gamedata`: `XERA_PHASE2_ID`, `NIKARE_ID`, `KENUT_ID`, `VOICE_OF_THE_FALLEN_ID` and `CLAW_OF_THE_FALLEN_ID`. |